xzj7019 commented on code in PR #32305:
URL: https://github.com/apache/doris/pull/32305#discussion_r1531437251
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpProjectUnderLimit.java:
##########
@@ -36,9 +37,10 @@
public class PullUpProjectUnderLimit extends OneRewriteRuleFactory {
@Override
public Rule build() {
- return logicalLimit(logicalProject().whenNot(p -> p.isAllSlots()))
+ return logicalLimit(logicalProject(logicalJoin().when(j ->
j.getJoinType().isLeftRightOuterOrCrossJoin()))
Review Comment:
Does it reduce the scope of this rule if adding the join pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
