cambyzju commented on code in PR #32583:
URL: https://github.com/apache/doris/pull/32583#discussion_r1533180662
##########
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##########
@@ -678,7 +678,7 @@ class AggregateFunctionCollect
Arena* arena, const size_t
num_rows) const override {
if constexpr (ShowNull::value) {
for (size_t i = 0; i != num_rows; ++i) {
- if (places[i] + offset) {
+ if (places[i] || offset) {
Review Comment:
maybe the correct answer is like: `if(places[i] && offset <
places[i].size())`, check `offset != 0 or == 0` is strange here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
