github-actions[bot] commented on code in PR #33216:
URL: https://github.com/apache/doris/pull/33216#discussion_r1549143896
##########
be/src/vec/columns/column.h:
##########
@@ -659,6 +659,9 @@ class IColumn : public COW<IColumn> {
/// Implies is_fixed_and_contiguous.
virtual bool is_numeric() const { return false; }
+ // Column is ColumnString/ColumnArray/ColumnMap or other variable length
column at every row
+ virtual bool is_variable_length() const { return false; }
Review Comment:
warning: function 'is_variable_length' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] virtual bool is_variable_length() const { return false; }
```
##########
be/src/vec/columns/column_nullable.h:
##########
@@ -94,7 +94,7 @@ class ColumnNullable final : public COWHelper<IColumn,
ColumnNullable> {
}
MutableColumnPtr get_shrinked_column() override;
-
+ bool is_variable_length() const override { return
nested_column->is_variable_length(); }
Review Comment:
warning: function 'is_variable_length' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_variable_length() const override { return
nested_column->is_variable_length(); }
```
##########
be/src/vec/columns/column_string.h:
##########
@@ -107,7 +107,7 @@ class ColumnString final : public COWHelper<IColumn,
ColumnString> {
public:
void sanity_check() const;
-
+ bool is_variable_length() const override { return true; }
Review Comment:
warning: function 'is_variable_length' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_variable_length() const override { return true; }
```
##########
be/src/vec/columns/column_const.h:
##########
@@ -75,6 +75,8 @@ class ColumnConst final : public COWHelper<IColumn,
ColumnConst> {
ColumnPtr convert_to_full_column_if_const() const override { return
convert_to_full_column(); }
+ bool is_variable_length() const override { return
data->is_variable_length(); }
Review Comment:
warning: function 'is_variable_length' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_variable_length() const override { return
data->is_variable_length(); }
```
##########
be/src/vec/columns/column_map.h:
##########
@@ -93,6 +93,7 @@ class ColumnMap final : public COWHelper<IColumn, ColumnMap> {
}
MutableColumnPtr clone_resized(size_t size) const override;
+ bool is_variable_length() const override { return true; }
Review Comment:
warning: function 'is_variable_length' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_variable_length() const override { return true; }
```
##########
be/src/vec/columns/column_array.h:
##########
@@ -127,6 +127,7 @@ class ColumnArray final : public COWHelper<IColumn,
ColumnArray> {
const char* get_family_name() const override { return "Array"; }
bool is_column_array() const override { return true; }
bool can_be_inside_nullable() const override { return true; }
+ bool is_variable_length() const override { return true; }
Review Comment:
warning: function 'is_variable_length' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_variable_length() const override { return true; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
