SWJTU-ZhangLei commented on code in PR #33321:
URL: https://github.com/apache/doris/pull/33321#discussion_r1554912928
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java:
##########
@@ -701,6 +701,32 @@ public void dropMaterializedIndex(long tableId, List<Long>
indexIds, boolean dro
}
}
+ /**
+ * for cloud mode, drop rollupIndex/materializedIndexId in kv meta store
+ * @param tableId
+ * @param materializedIndexId
+ */
+ public void eraseIndexDropBackendReplicas(long tableId, List<Long>
indexIdList) {
+ if (indexIdList == null || indexIdList.size() == 0) {
+ LOG.warn("indexIdList is empty");
+ return;
+ }
+ long tryTimes = 1;
+ while (true) {
Review Comment:
> avoid using an infinite loop. try hundreds of times and return with an
error log.
resolved
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java:
##########
@@ -701,6 +701,32 @@ public void dropMaterializedIndex(long tableId, List<Long>
indexIds, boolean dro
}
}
+ /**
+ * for cloud mode, drop rollupIndex/materializedIndexId in kv meta store
+ * @param tableId
+ * @param materializedIndexId
+ */
+ public void eraseIndexDropBackendReplicas(long tableId, List<Long>
indexIdList) {
Review Comment:
> This is a cofusing name, consider `eraseDroppedIndex`
resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
