xiedeyantu commented on code in PR #33272:
URL: https://github.com/apache/doris/pull/33272#discussion_r1554974466
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/visitor/ScalarFunctionVisitor.java:
##########
@@ -2011,6 +2012,10 @@ default R visitInttoUuid(InttoUuid inttoUuid, C context)
{
return visitScalarFunction(inttoUuid, context);
}
+ default R visitStrcmp(Strcmp strcmp, C context) {
+ return visitScalarFunction(strcmp, context);
Review Comment:
> add to legacy planner too~
ok
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java:
##########
@@ -628,6 +629,7 @@ public class BuiltinScalarFunctions implements
FunctionHelper {
scalar(InnerProduct.class, "inner_product"),
scalar(Instr.class, "instr"),
scalar(InttoUuid.class, "int_to_uuid"),
+ scalar(Strcmp.class, "strcmp"),
Review Comment:
> add with lexicographical order
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]