github-actions[bot] commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1555583551
##########
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:
##########
@@ -88,5 +88,25 @@ Status
DataTypeIPv4SerDe::deserialize_one_cell_from_json(IColumn& column, Slice&
return Status::OK();
}
+Status DataTypeIPv4SerDe::write_column_to_pb(const IColumn& column, PValues&
result, int start,
Review Comment:
warning: method 'write_column_to_pb' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:91:
```diff
- int end) const {
+ int end) {
```
be/src/vec/data_types/serde/data_type_ipv4_serde.h:52:
```diff
- Status write_column_to_pb(const IColumn& column, PValues& result, int
start,
- int end) const override;
+ static Status write_column_to_pb(const IColumn& column, PValues&
result, int start,
+ int end) override;
```
##########
be/src/vec/data_types/serde/data_type_ipv6_serde.cpp:
##########
@@ -88,5 +89,28 @@ Status
DataTypeIPv6SerDe::deserialize_one_cell_from_json(IColumn& column, Slice&
return Status::OK();
}
+Status DataTypeIPv6SerDe::write_column_to_pb(const IColumn& column, PValues&
result, int start,
Review Comment:
warning: method 'write_column_to_pb' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/data_types/serde/data_type_ipv6_serde.cpp:92:
```diff
- int end) const {
+ int end) {
```
be/src/vec/data_types/serde/data_type_ipv6_serde.h:55:
```diff
- Status write_column_to_pb(const IColumn& column, PValues& result, int
start,
- int end) const override;
+ static Status write_column_to_pb(const IColumn& column, PValues&
result, int start,
+ int end) override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
