github-actions[bot] commented on code in PR #33397:
URL: https://github.com/apache/doris/pull/33397#discussion_r1556762752
##########
be/src/vec/exec/skewed_partition_rebalancer.h:
##########
@@ -60,9 +61,13 @@ class SkewedPartitionRebalancer {
struct TaskBucket {
int task_id;
int id;
+ std::string task_address;
- TaskBucket(int task_id_, int bucket_id_, int task_bucket_count_)
- : task_id(task_id_), id(task_id_ * task_bucket_count_ +
bucket_id_) {}
+ TaskBucket(int task_id_, int bucket_id_, int task_bucket_count_,
+ const std::string& task_address_)
Review Comment:
warning: pass by value and use std::move [modernize-pass-by-value]
```suggestion
std::string task_address_)
```
be/src/vec/exec/skewed_partition_rebalancer.h:69:
```diff
- task_address(task_address_) {}
+ task_address(std::move(task_address_)) {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
