github-actions[bot] commented on code in PR #33243:
URL: https://github.com/apache/doris/pull/33243#discussion_r1562016051
##########
be/src/vec/functions/function_string.h:
##########
@@ -3914,4 +3914,138 @@ class FunctionIntToChar : public IFunction {
#endif
}
};
+
+class FunctionStrInsert : public IFunction {
+public:
+ static constexpr auto name = "str_insert";
+ static FunctionPtr create() { return
std::make_shared<FunctionStrInsert>(); }
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 4; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeString>();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override
{
+ DCHECK_EQ(arguments.size(), 4);
+
+ bool col_const[4];
+ ColumnPtr argument_columns[4];
+ for (int i = 0; i < 4; ++i) {
+ std::tie(argument_columns[i], col_const[i]) =
+
unpack_if_const(block.get_by_position(arguments[i]).column);
+ }
+ const auto* col_origin = assert_cast<const
ColumnString*>(argument_columns[0].get());
+
+ const auto* col_pos = assert_cast<const
ColumnVector<Int32>*>(argument_columns[1].get())
+ ->get_data()
+ .data();
+ const auto* col_len = assert_cast<const
ColumnVector<Int32>*>(argument_columns[2].get())
+ ->get_data()
+ .data();
+ const auto* col_insert = assert_cast<const
ColumnString*>(argument_columns[3].get());
+
+ ColumnString::MutablePtr col_res = ColumnString::create();
+
+ if (col_const[1] && col_const[2] && col_const[3]) {
+ vector_const(col_origin, col_pos, col_len, col_insert, col_res,
col_const[0],
+ input_rows_count);
+ } else if (col_const[1]) {
+ vector<true>(col_origin, col_pos, col_len, col_insert, col_res,
col_const,
+ input_rows_count);
+ } else {
+ vector<false>(col_origin, col_pos, col_len, col_insert, col_res,
col_const,
+ input_rows_count);
+ }
+
+ block.replace_by_position(result, std::move(col_res));
+ return Status::OK();
+ }
+
+private:
+ // get the new str size
+ static std::pair<bool, size_t> get_size(size_t& str_size, int& pos, int&
len,
+ size_t& ins_size) {
+ if (pos > str_size || pos < 1) {
+ return {true, str_size};
+ }
+ if (len < 0 || pos + len - 1 >= str_size) {
+ len = str_size - pos + 1;
+ return {false, pos + ins_size - 1};
+ }
+ return {false, str_size - len + ins_size};
+ }
+
+ static void vector_const(const ColumnString* col_origin, int const*
col_pos, int const* col_len,
+ const ColumnString* col_insert,
ColumnString::MutablePtr& col_res,
+ bool origin_const, size_t input_rows_count) {
+ auto& col_res_chars = col_res->get_chars();
+ auto& col_res_offsets = col_res->get_offsets();
+ StringRef origin_str;
+ StringRef insert_str = col_insert->get_data_at(0);
+ auto pos = col_pos[0];
+ auto len = col_len[0];
+ for (size_t i = 0; i < input_rows_count; i++) {
+ origin_str = col_origin->get_data_at(i);
+
+ if (auto [is_origin, offset] = get_size(origin_str.size, pos, len,
insert_str.size);
+ is_origin) {
+ col_res->insert_data(origin_str.data, offset);
+ } else {
+ const auto old_size = col_res_chars.size();
+ col_res_chars.resize(old_size + offset);
+ // There are three stages here
+ // 1. copy origin_str with index 0 to pos - 2
+ // 2. copy all of insert_str.
+ // 3. copy origin_str from pos+len-1 to the end of the line.
+ memcpy(col_res_chars.data() + old_size, origin_str.data, pos -
1);
+ memcpy(col_res_chars.data() + old_size + pos - 1,
insert_str.data, insert_str.size);
+ memcpy(col_res_chars.data() + old_size + pos - 1 +
insert_str.size,
+ origin_str.data + pos + len - 1, origin_str.size - pos
- len + 1);
+ col_res_offsets.push_back(offset + old_size);
+ }
+ }
+ }
+
+ template <bool pos_const>
+ static void vector(const ColumnString* col_origin, int const* col_pos, int
const* col_len,
+ const ColumnString* col_insert,
ColumnString::MutablePtr& col_res,
+ bool col_const[4], size_t input_rows_count) {
Review Comment:
warning: pointer parameter 'col_const' can be pointer to const
[readability-non-const-parameter]
```suggestion
ablePtr& col_res,const
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
