Yukang-Lian commented on code in PR #33481:
URL: https://github.com/apache/doris/pull/33481#discussion_r1565244481
##########
be/src/pipeline/exec/group_commit_block_sink_operator.h:
##########
@@ -30,7 +31,7 @@ class GroupCommitBlockSinkOperatorBuilder final
GroupCommitBlockSinkOperatorBuilder(int32_t id, DataSink* sink)
: DataSinkOperatorBuilder(id, "GroupCommitBlockSinkOperator",
sink) {}
- OperatorPtr build_operator() override;
+ inline OperatorPtr build_operator() override;
Review Comment:
build_operator() implemented in group_commit_block_sink_operator.h. Without
inline, there will be compile error "multiple definitions".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
