xiaokang commented on code in PR #33076:
URL: https://github.com/apache/doris/pull/33076#discussion_r1566582361
##########
be/src/http/action/compaction_action.cpp:
##########
@@ -243,7 +258,14 @@ Status
CompactionAction::_execute_compaction_callback(TabletSharedPtr tablet,
RETURN_IF_ERROR(compaction.prepare_compact());
return compaction.execute_compact();
};
- if (compaction_type == PARAM_COMPACTION_BASE) {
+ if (fetch_from_remote) {
+ SingleReplicaCompaction single_compaction(_engine, tablet);
+ res = do_compact(single_compaction);
Review Comment:
line 148 should_fetch_from_peer() does not check single_replica compaction
enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
