kaijchen commented on code in PR #32845:
URL: https://github.com/apache/doris/pull/32845#discussion_r1558066309
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/NativeInsertStmt.java:
##########
@@ -1023,13 +1023,16 @@ private DataSink createDataSink() throws
AnalysisException {
}
if (targetTable instanceof OlapTable) {
OlapTableSink sink;
+ final boolean enableSingleReplicaLoad =
+
analyzer.getContext().getSessionVariable().isEnableMemtableOnSinkNode()
+ ? false :
analyzer.getContext().getSessionVariable().isEnableSingleReplicaInsert();
if (isGroupCommitStreamLoadSql) {
sink = new GroupCommitBlockSink((OlapTable) targetTable,
olapTuple,
- targetPartitionIds,
analyzer.getContext().getSessionVariable().isEnableSingleReplicaInsert(),
+ targetPartitionIds, enableSingleReplicaLoad,
ConnectContext.get().getSessionVariable().getGroupCommit(), 0);
} else {
sink = new OlapTableSink((OlapTable) targetTable, olapTuple,
targetPartitionIds,
-
analyzer.getContext().getSessionVariable().isEnableSingleReplicaInsert());
+ enableSingleReplicaLoad);
Review Comment:
This is a parameter configured by the user, in this case through session
variables.
What do you mean "add this feature to nereids"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
