HappenLee commented on code in PR #33595:
URL: https://github.com/apache/doris/pull/33595#discussion_r1568370597
##########
be/src/vec/exprs/table_function/table_function_factory.cpp:
##########
@@ -65,22 +69,26 @@ const std::unordered_map<std::string,
std::function<std::unique_ptr<TableFunctio
{"explode_map", TableFunctionCreator<VExplodeMapTableFunction>
{}},
{"explode", TableFunctionCreator<VExplodeTableFunction> {}}};
-Status TableFunctionFactory::get_fn(const std::string& fn_name_raw,
ObjectPool* pool,
- TableFunction** fn) {
- bool is_outer = match_suffix(fn_name_raw, COMBINATOR_SUFFIX_OUTER);
- std::string fn_name_real =
- is_outer ? remove_suffix(fn_name_raw, COMBINATOR_SUFFIX_OUTER) :
fn_name_raw;
+Status TableFunctionFactory::get_fn(const TFunction& t_fn, ObjectPool* pool,
TableFunction** fn) {
+ const std::string fn_name_raw = t_fn.name.function_name;
Review Comment:
should not be call before if，because semms useless in if {}.
and use `std::string_view` or reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
