This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
commit ce971b1da466ef9c98470aa50eb3efb8f0a0f075
Author: zhannngchen <48427519+zhannngc...@users.noreply.github.com>
AuthorDate: Wed Apr 17 11:10:34 2024 +0800
[fix](chore) update some CHECK to CHECK_EQ, to print more details while
CHECK failed (#33709)
---
be/src/olap/rowset/segment_v2/segment_writer.cpp | 6 +++---
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/be/src/olap/rowset/segment_v2/segment_writer.cpp
b/be/src/olap/rowset/segment_v2/segment_writer.cpp
index a7d162a8bf4..dc85408accd 100644
--- a/be/src/olap/rowset/segment_v2/segment_writer.cpp
+++ b/be/src/olap/rowset/segment_v2/segment_writer.cpp
@@ -565,7 +565,7 @@ Status
SegmentWriter::append_block_with_partial_content(const vectorized::Block*
{loc.rowset_id, loc.segment_id,
DeleteBitmap::TEMP_VERSION_COMMON}, loc.row_id);
}
}
- CHECK(use_default_or_null_flag.size() == num_rows);
+ CHECK_EQ(use_default_or_null_flag.size(), num_rows);
if (config::enable_merge_on_write_correctness_check) {
tablet->add_sentinel_mark_to_delete_bitmap(_mow_context->delete_bitmap.get(),
@@ -643,7 +643,7 @@ Status
SegmentWriter::fill_missing_columns(vectorized::MutableColumns& mutable_f
// create old value columns
const auto& cids_missing =
_opts.rowset_ctx->partial_update_info->missing_cids;
auto old_value_block = _tablet_schema->create_block_by_cids(cids_missing);
- CHECK(cids_missing.size() == old_value_block.columns());
+ CHECK_EQ(cids_missing.size(), old_value_block.columns());
bool has_row_column = _tablet_schema->store_row_column();
// record real pos, key is input line num, value is old_block line num
std::map<uint32_t, uint32_t> read_index;
@@ -1191,7 +1191,7 @@ Status SegmentWriter::_write_short_key_index() {
}
Status SegmentWriter::_write_primary_key_index() {
- CHECK(_primary_key_index_builder->num_rows() == _row_count);
+ CHECK_EQ(_primary_key_index_builder->num_rows(), _row_count);
return
_primary_key_index_builder->finalize(_footer.mutable_primary_key_index_meta());
}
diff --git a/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp
b/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp
index 603f19900dd..d94bb0ce3fe 100644
--- a/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp
+++ b/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp
@@ -497,7 +497,7 @@ Status
VerticalSegmentWriter::_append_block_with_partial_content(RowsInBlock& da
{loc.rowset_id, loc.segment_id,
DeleteBitmap::TEMP_VERSION_COMMON}, loc.row_id);
}
}
- CHECK(use_default_or_null_flag.size() == data.num_rows);
+ CHECK_EQ(use_default_or_null_flag.size(), data.num_rows);
if (config::enable_merge_on_write_correctness_check) {
tablet->add_sentinel_mark_to_delete_bitmap(_mow_context->delete_bitmap.get(),
@@ -575,7 +575,7 @@ Status VerticalSegmentWriter::_fill_missing_columns(
// create old value columns
const auto& missing_cids =
_opts.rowset_ctx->partial_update_info->missing_cids;
auto old_value_block = _tablet_schema->create_block_by_cids(missing_cids);
- CHECK(missing_cids.size() == old_value_block.columns());
+ CHECK_EQ(missing_cids.size(), old_value_block.columns());
auto mutable_old_columns = old_value_block.mutate_columns();
bool has_row_column = _tablet_schema->store_row_column();
// record real pos, key is input line num, value is old_block line num
@@ -1047,7 +1047,7 @@ Status VerticalSegmentWriter::_write_short_key_index() {
}
Status VerticalSegmentWriter::_write_primary_key_index() {
- CHECK(_primary_key_index_builder->num_rows() == _row_count);
+ CHECK_EQ(_primary_key_index_builder->num_rows(), _row_count);
return
_primary_key_index_builder->finalize(_footer.mutable_primary_key_index_meta());
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
