yiguolei commented on code in PR #33934:
URL: https://github.com/apache/doris/pull/33934#discussion_r1573731994
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1957,7 +1957,10 @@ void SegmentIterator::_replace_version_col(size_t
num_rows) {
uint16_t SegmentIterator::_evaluate_vectorization_predicate(uint16_t*
sel_rowid_idx,
uint16_t
selected_size) {
SCOPED_RAW_TIMER(&_opts.stats->vec_cond_ns);
- if (_is_need_vec_eval) {
+ // The expr can only be skipped when _non_predicate_columns is not empty;
+ // otherwise, skipping the expr could result in an empty block
+ // being output while _non_predicate_columns is empty.
+ if (_is_need_vec_eval && !_non_predicate_columns.empty()) {
Review Comment:
why the output will be empty block? since we already read the predicate
column into current_return_columns and line 1970 will set all flags to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
