eldenmoon commented on code in PR #33403:
URL: https://github.com/apache/doris/pull/33403#discussion_r1577221131
##########
fe/fe-core/src/main/java/org/apache/doris/qe/MysqlConnectProcessor.java:
##########
@@ -116,7 +116,7 @@ private void handleExecute() {
String stmtStr = "";
try {
// new_params_bind_flag
- if ((int) packetBuf.get() != 0) {
+ if (packetBuf.hasRemaining() && (int) packetBuf.get() != 0) {
Review Comment:
please add more comment to explain the changes to mysql protocol in FE
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -2666,6 +2674,10 @@ private void sendStmtPrepareOK() throws IOException {
serializer.writeInt2(numParams);
// reserved_1
serializer.writeInt1(0);
+ // warning_count
Review Comment:
please add more comment to explain the changes to mysql protocol in FE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
