gavinchou commented on code in PR #34059:
URL: https://github.com/apache/doris/pull/34059#discussion_r1577325315
##########
regression-test/suites/vaults/create/create.groovy:
##########
@@ -61,6 +61,29 @@ suite("create_vault") {
);
"""
+ try_sql """
+ drop table create_table_use_vault
+ """
+
+ sql """
+ CREATE TABLE IF NOT EXISTS create_table_use_vault (
+ C_CUSTKEY INTEGER NOT NULL,
+ C_NAME INTEGER NOT NULL
+ )
+ DUPLICATE KEY(C_CUSTKEY, C_NAME)
+ DISTRIBUTED BY HASH(C_CUSTKEY) BUCKETS 1
+ PROPERTIES (
+ "replication_num" = "1",
+ "storage_vault_name" = "create_hdfs_vault"
+ )
+ """
+
+ def create_stmt = """
+ show create table create_table_use_vault
+ """
+
+ assertTrue(create_stmt.contains("\"storage_vault_name\" =
\"create_hdfs_vault\""))
Review Comment:
also print the teh sql result `create_stmt`
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -2394,7 +2394,7 @@ private void createOlapTable(Database db, CreateTableStmt
stmt) throws UserExcep
String storageVaultName =
PropertyAnalyzer.analyzeStorageVault(properties);
String storageVaultId = null;
// If user does not specify one storage vault then FE would use the
default vault
- if (storageVaultName == null || !storageVaultName.isEmpty()) {
+ if (storageVaultName == null || storageVaultName.isEmpty()) {
Review Comment:
Strings.isNullOrEmpty()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
