dataroaring commented on code in PR #32980:
URL: https://github.com/apache/doris/pull/32980#discussion_r1579500655
##########
regression-test/suites/insert_p0/txn_insert.groovy:
##########
@@ -328,19 +480,44 @@ suite("txn_insert") {
where txn_insert_dt4.id = txn_insert_dt2.id;
"""
sql """
- delete from txn_insert_dt2 where id = 1 or id = 5;
+ delete from txn_insert_dt2 where id = 1;
"""
sql """
- delete from txn_insert_dt5 partition(p_20000102) where id = 1
or id = 5;
+ delete from txn_insert_dt2 where id = 5;
+ """
Review Comment:
what if
begin
insert into t1;
delete from t1;
insert into t2 select * from t1;
commit;
result of first insert is visible to delete but not visible to the second
insert.
##########
regression-test/suites/insert_p0/txn_insert.groovy:
##########
@@ -328,19 +480,44 @@ suite("txn_insert") {
where txn_insert_dt4.id = txn_insert_dt2.id;
"""
sql """
- delete from txn_insert_dt2 where id = 1 or id = 5;
+ delete from txn_insert_dt2 where id = 1;
"""
sql """
- delete from txn_insert_dt5 partition(p_20000102) where id = 1
or id = 5;
+ delete from txn_insert_dt2 where id = 5;
+ """
Review Comment:
> > Thread1 t2: insert into table1 Thread2 t1: insert into table2 select
table1, t3: insert into table2 select table1.
> > Is result of t2 visible to insert at t3?
>
> yes
For clarity,
Thread1 t2: begin insert into table1; commit
thread2 t1:begin insert into table 2 select table2; t3: insert into table2
select table1; commit
If yes, what's our isolation level? ReadCommitted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
