kaka11chen commented on code in PR #33937:
URL: https://github.com/apache/doris/pull/33937#discussion_r1581004458
##########
fe/fe-core/src/main/java/org/apache/doris/fs/remote/ObjFileSystem.java:
##########
@@ -43,11 +44,20 @@ public ObjFileSystem(String name,
StorageBackend.StorageType type, ObjStorage<?>
this.objStorage = objStorage;
}
+ public ObjStorage<?> getObjStorage() {
+ return objStorage;
+ }
+
@Override
public Status exists(String remotePath) {
return objStorage.headObject(remotePath);
}
+ @Override
+ public Status directoryExists(String dir) {
+ return listFiles(dir, false, new ArrayList<>());
Review Comment:
headObject can not used by directory exists，it doesn't work because actually
obj system didn't has real directory concept.
##########
fe/fe-core/src/main/java/org/apache/doris/fs/remote/ObjFileSystem.java:
##########
@@ -43,11 +44,20 @@ public ObjFileSystem(String name,
StorageBackend.StorageType type, ObjStorage<?>
this.objStorage = objStorage;
}
+ public ObjStorage<?> getObjStorage() {
+ return objStorage;
+ }
+
@Override
public Status exists(String remotePath) {
return objStorage.headObject(remotePath);
}
+ @Override
+ public Status directoryExists(String dir) {
+ return listFiles(dir, false, new ArrayList<>());
Review Comment:
headObject can not used by directory exists，it doesn't work because actually
obj file system didn't has real directory concept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
