gavinchou commented on code in PR #34195:
URL: https://github.com/apache/doris/pull/34195#discussion_r1581276205
##########
cloud/src/meta-service/meta_service_resource.cpp:
##########
@@ -757,6 +757,11 @@ void
MetaServiceImpl::alter_obj_store_info(google::protobuf::RpcController* cont
vault.mutable_obj_info()->MergeFrom(last_item);
auto vault_key = storage_vault_key({instance.instance_id(),
last_item.id()});
txn->put(vault_key, vault.SerializeAsString());
+ if (request->has_set_as_default_storage_vault() &&
+ request->set_as_default_storage_vault()) {
+ instance.set_default_storage_vault_id(vault.id());
+ instance.set_default_storage_vault_name(vault.name());
+ }
Review Comment:
Ensure that there is enough log for all vault operations.
And, also log if there is already an existed default vault which has been
replaced.
##########
cloud/src/meta-service/meta_service_resource.cpp:
##########
@@ -757,6 +757,11 @@ void
MetaServiceImpl::alter_obj_store_info(google::protobuf::RpcController* cont
vault.mutable_obj_info()->MergeFrom(last_item);
auto vault_key = storage_vault_key({instance.instance_id(),
last_item.id()});
txn->put(vault_key, vault.SerializeAsString());
+ if (request->has_set_as_default_storage_vault() &&
+ request->set_as_default_storage_vault()) {
+ instance.set_default_storage_vault_id(vault.id());
+ instance.set_default_storage_vault_name(vault.name());
+ }
Review Comment:
Ensure that there is enough log for all vault operations.
And, also log if there is already an existing default vault that has been
replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
