github-actions[bot] commented on code in PR #34264:
URL: https://github.com/apache/doris/pull/34264#discussion_r1582166201
##########
be/src/vec/core/column_with_type_and_name.cpp:
##########
@@ -62,17 +62,15 @@ void ColumnWithTypeAndName::dump_structure(std::ostream&
out) const {
out << name;
}
- if (type) {
+ if (type)
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (type) {
```
be/src/vec/core/column_with_type_and_name.cpp:66:
```diff
- else
+ } else
```
##########
be/src/vec/core/column_with_type_and_name.cpp:
##########
@@ -62,17 +62,15 @@
out << name;
}
- if (type) {
+ if (type)
out << " " << type->get_name();
- } else {
+ else
out << " nullptr";
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
else {
out << " nullptr";
}
```
##########
be/src/vec/core/column_with_type_and_name.cpp:
##########
@@ -62,17 +62,15 @@
out << name;
}
- if (type) {
+ if (type)
out << " " << type->get_name();
- } else {
+ else
out << " nullptr";
- }
- if (column) {
- out << ' ' << column->dump_structure() << "(use_count=" <<
column->use_count() << ')';
- } else {
+ if (column)
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (column) {
```
be/src/vec/core/column_with_type_and_name.cpp:71:
```diff
- else
+ } else
```
##########
be/src/vec/core/column_with_type_and_name.cpp:
##########
@@ -62,17 +62,15 @@
out << name;
}
- if (type) {
+ if (type)
out << " " << type->get_name();
- } else {
+ else
out << " nullptr";
- }
- if (column) {
- out << ' ' << column->dump_structure() << "(use_count=" <<
column->use_count() << ')';
- } else {
+ if (column)
+ out << ' ' << column->dump_structure();
+ else
out << " nullptr";
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
else {
out << " nullptr";
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
