github-actions[bot] commented on code in PR #34375:
URL: https://github.com/apache/doris/pull/34375#discussion_r1585995981
##########
be/src/olap/rowset/segment_v2/segment_iterator.h:
##########
@@ -72,18 +72,20 @@ struct ColumnPredicateInfo {
std::string debug_string() const {
std::stringstream ss;
ss << "column_name=" << column_name << ", query_op=" << query_op
- << ", query_value=" << query_value;
+ << ", query_value=" << join(query_values, ",");
return ss.str();
}
- bool is_empty() const { return column_name.empty() && query_value.empty()
&& query_op.empty(); }
+ bool is_empty() const {
Review Comment:
warning: function 'is_empty' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool is_empty() const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
