gavinchou commented on code in PR #34340:
URL: https://github.com/apache/doris/pull/34340#discussion_r1587205722
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/Config.groovy:
##########
@@ -837,10 +845,27 @@ class Config {
}
}
+ boolean fetchRunMode() {
Review Comment:
It's better just return the actual mode for the name `fetchRunMode()`
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Suite.groovy:
##########
@@ -1123,7 +1124,7 @@ class Suite implements GroovyInterceptable {
}
boolean isCloudMode() {
- return !getFeConfig("cloud_unique_id").isEmpty()
+ return context.config.fetchRunMode()
Review Comment:
return fetchMode == cloudMode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
