morningman commented on code in PR #34413:
URL: https://github.com/apache/doris/pull/34413#discussion_r1590806568
##########
fe/fe-core/src/main/java/org/apache/doris/backup/Repository.java:
##########
@@ -747,9 +747,9 @@ public String getCreateStatement() {
Map<String, String> properties = new HashMap();
properties.putAll(this.getRemoteFileSystem().getProperties());
// WE should not return the acturl secret key to user for safety
consideration
- List<String> secretKeys = Lists.newArrayList(S3Properties.SECRET_KEY,
S3Properties.Env.SECRET_KEY,
- AuthenticationConfig.HADOOP_SECURITY_AUTHENTICATION,
- AuthenticationConfig.HADOOP_KERBEROS_AUTHORIZATION);
+ List<String> secretKeys = List.of(S3Properties.SECRET_KEY,
S3Properties.Env.SECRET_KEY,
Review Comment:
Do not use `List.of`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
