yiguolei commented on code in PR #34805:
URL: https://github.com/apache/doris/pull/34805#discussion_r1599522308
##########
be/src/pipeline/dependency.h:
##########
@@ -84,24 +83,27 @@ struct BasicSharedState {
Dependency* create_sink_dependency(int dest_id, int node_id, std::string
name);
};
+/**
+ * We divide dependency into three categories:
+ * 1. BEFORE_EXECUTION: pipeline tasks need to wait for this before execution.
(i.e. ExecutionDependency, RuntimeFilterDependency)
+ * 2. DURING_EXECUTION: In execution phase, tasks should be running only if
this dependency is ready. (i.e. Read/Write Dependency)
+ * 3. AFTER_EXECUTION: After execution phase, tasks should be closed after
this dependency is ready.
+ */
+enum class DependencyType : uint8_t {
Review Comment:
We should not add dependency type.
It is very difficult for the developer to use. Many developer will not know
the type related with wake up method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
