w41ter commented on code in PR #34615:
URL: https://github.com/apache/doris/pull/34615#discussion_r1601041293
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -381,6 +383,7 @@ void
MetaServiceImpl::batch_get_version(::google::protobuf::RpcController* contr
break;
}
response->add_versions(version);
+ // TODO response->add_version_update_times_ms();
Review Comment:
```suggestion
```
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -261,6 +261,7 @@ void
MetaServiceImpl::get_version(::google::protobuf::RpcController* controller,
return;
}
response->set_version(version);
+ // TODO response->set_version_update_time_ms();
Review Comment:
```suggestion
```
##########
fe/fe-core/src/main/java/org/apache/doris/qe/cache/CacheAnalyzer.java:
##########
@@ -697,15 +700,29 @@ private CacheTable
buildCacheTableForOlapScanNode(OlapScanNode node) {
CatalogIf catalog = database.getCatalog();
ScanTable scanTable = new ScanTable(
new FullTableName(catalog.getName(), database.getFullName(),
olapTable.getName()),
- olapTable.getVisibleVersionTime(),
olapTable.getVisibleVersion());
+ olapTable.getVisibleVersion());
scanTables.add(scanTable);
+ if (Config.isCloudMode()) {
+ // get version of related partitions in batch
Review Comment:
How about extracting this operation into `OlapTable`, just like
`OlapTable.selectNonEmptyPartitionIds`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
