wuwenchi commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1604421627
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -1362,15 +1363,27 @@ public LogicalPlan visitTableName(TableNameContext ctx)
{
scanParams = new
TableScanParams(ctx.optScanParams().funcName.getText(), map);
}
+ TableSnapshot tableSnapshot = null;
+ if (ctx.tableSnapshot() != null) {
+ if (ctx.tableSnapshot().TIME() != null) {
+ tableSnapshot = new
TableSnapshot(stripQuotes(ctx.tableSnapshot().time.getText()));
+ tableSnapshot.setType(TableSnapshot.VersionType.TIME);
Review Comment:
The corresponding type has been set in the constructor of `TableSnapshot`,
why should we set it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
