Re: [PR] [Chore](runtime-filter) adjust some check and error msg on runtime filter [doris]

Sat, 18 May 2024 09:20:40 -0700 


yiguolei commented on code in PR #35018:
URL: https://github.com/apache/doris/pull/35018#discussion_r1605813382


##########
be/src/runtime/runtime_filter_mgr.cpp:
##########
@@ -411,7 +411,8 @@ Status RuntimeFilterMergeControllerEntity::merge(const 
PMergeFilterRequest* requ
         RuntimeFilterWrapperHolder holder;
         RETURN_IF_ERROR(IRuntimeFilter::create_wrapper(&params, pool, 
holder.getHandle()));
 
-        
RETURN_IF_ERROR(cnt_val->filter->merge_from(holder.getHandle()->get()));
+        // prevent error ignored
+        CHECK(cnt_val->filter->merge_from(holder.getHandle()->get())) << "rf 
merge failed";

Review Comment:
   why check here？ It will core online.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to