github-actions[bot] commented on code in PR #35235:
URL: https://github.com/apache/doris/pull/35235#discussion_r1611057016
##########
be/src/vec/functions/function_fake.h:
##########
@@ -53,7 +64,12 @@ class FunctionFake : public IFunction {
return Impl::get_return_type_impl(arguments);
}
- bool use_default_implementation_for_nulls() const override { return true; }
+ bool use_default_implementation_for_nulls() const override {
+ if constexpr (std::is_same_v<Impl, UDTFImpl>) {
+ return false;
Review Comment:
warning: redundant boolean literal in conditional return statement
[readability-simplify-boolean-expr]
be/src/vec/functions/function_fake.h:67:
```diff
- if constexpr (std::is_same_v<Impl, UDTFImpl>) {
- return false;
- }
- return true;
+ return !static_cast<bool>(std::is_same_v<Impl, UDTFImpl>);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
