xzj7019 commented on code in PR #35440:
URL: https://github.com/apache/doris/pull/35440#discussion_r1616536078
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/properties/FuncDeps.java:
##########
@@ -78,6 +82,32 @@ public boolean isEmpty() {
return items.isEmpty();
}
+ private void dfs(Set<Slot> parent, Set<Set<Slot>> visited,
Set<FuncDepsItem> circleItem) {
Review Comment:
Seems that current circleItem depends on traversing order, and if the useful
item is removed by chance, will we can't do the cooresponding opt at that time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
