github-actions[bot] commented on code in PR #35513:
URL: https://github.com/apache/doris/pull/35513#discussion_r1616762469
##########
be/src/pipeline/exec/exchange_sink_buffer.h:
##########
@@ -192,11 +192,11 @@ struct ExchangeRpcContext {
};
// Each ExchangeSinkOperator have one ExchangeSinkBuffer
-class ExchangeSinkBuffer : public HasTaskExecutionCtx {
+class ExchangeSinkBuffer final : public HasTaskExecutionCtx {
public:
ExchangeSinkBuffer(PUniqueId query_id, PlanNodeId dest_node_id, int
send_id, int be_number,
RuntimeState* state);
- ~ExchangeSinkBuffer();
+ ~ExchangeSinkBuffer() = default;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
~ExchangeSinkBuffer() override = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
