morningman commented on code in PR #35431:
URL: https://github.com/apache/doris/pull/35431#discussion_r1617511064
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -128,6 +128,7 @@ public class SessionVariable implements Serializable,
Writable {
public static final String PROFILE_LEVEL = "profile_level";
public static final String MAX_INSTANCE_NUM = "max_instance_num";
public static final String ENABLE_INSERT_STRICT = "enable_insert_strict";
+ public static final String MAX_FILTER_RATIO = "max_filter_ratio";
Review Comment:
```suggestion
public static final String INSERT_MAX_FILTER_RATIO =
"insert_max_filter_ratio";
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/AbstractInsertExecutor.java:
##########
@@ -173,6 +173,12 @@ private void checkStrictMode() throws Exception {
ErrorReport.reportDdlException("Insert has filtered data in
strict mode",
ErrorCode.ERR_FAILED_WHEN_INSERT);
}
+ } else {
Review Comment:
Change the method name to `checkStrictModeAndFilterRatio`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
