github-actions[bot] commented on code in PR #35647:
URL: https://github.com/apache/doris/pull/35647#discussion_r1620163935
##########
be/src/olap/rowset/segment_v2/zone_map_index.cpp:
##########
@@ -173,9 +175,18 @@ Status ZoneMapIndexReader::_load(bool use_page_cache, bool
kept_in_memory,
return Status::Corruption("Failed to parse zone map");
}
}
+
+ g_zone_map_memory_bytes << sizeof(*this) + sizeof(ZoneMapPB) *
_page_zone_maps.size() +
+ sizeof(IndexedColumnMetaPB);
+
return Status::OK();
}
+ZoneMapIndexReader::~ZoneMapIndexReader() {
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```cpp
ZoneMapIndexReader::~ZoneMapIndexReader() {
^
```
##########
be/src/olap/rowset/segment_v2/ordinal_page_index.cpp:
##########
@@ -146,5 +154,12 @@ OrdinalPageIndexIterator
OrdinalIndexReader::seek_at_or_before(ordinal_t ordinal
return OrdinalPageIndexIterator(this, left);
}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```cpp
OrdinalIndexReader::~OrdinalIndexReader() {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
