cambyzju commented on code in PR #35722:
URL: https://github.com/apache/doris/pull/35722#discussion_r1622305733
##########
be/src/io/cache/block_file_cache_factory.cpp:
##########
@@ -92,16 +92,20 @@ Status FileCacheFactory::create_file_cache(const
std::string& cache_base_path,
}
auto cache = std::make_unique<BlockFileCache>(cache_base_path,
file_cache_settings);
RETURN_IF_ERROR(cache->initialize());
- _path_to_cache[cache_base_path] = cache.get();
- _caches.push_back(std::move(cache));
+ {
Review Comment:
At the beginnig of this function, the filesystem operations also have
concurrency problem? such as:
```
fs->exists
fs->create_directory
fs->delete_directory
fs->create_directory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
