zhiqiang-hhhh commented on code in PR #35883:
URL: https://github.com/apache/doris/pull/35883#discussion_r1627606425
##########
be/src/vec/runtime/vdatetime_value.h:
##########
@@ -822,7 +823,8 @@ class DateV2Value {
return val;
}
- bool to_format_string(const char* format, int len, char* to) const;
+ bool to_format_string(const char* format, int len, char* to,
+ int max_valid_length = 10000) const;
Review Comment:
maybe no default value is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
