github-actions[bot] commented on code in PR #36305:
URL: https://github.com/apache/doris/pull/36305#discussion_r1640046030
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -102,7 +102,7 @@ void VMysqlResultWriter<is_binary_format>::_init_profile() {
}
template <bool is_binary_format>
-Status VMysqlResultWriter<is_binary_format>::write(Block& input_block) {
+Status VMysqlResultWriter<is_binary_format>::write(RuntimeState* state, Block&
input_block) {
Review Comment:
warning: function 'write' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status VMysqlResultWriter<is_binary_format>::write(RuntimeState* state,
Block& input_block) {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/sink/vmysql_result_writer.cpp:104:** 107 lines including
whitespace and comments (threshold 80)
```cpp
Status VMysqlResultWriter<is_binary_format>::write(RuntimeState* state,
Block& input_block) {
^
```
</details>
##########
be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:
##########
@@ -105,7 +105,7 @@ VIcebergTableWriter::_to_iceberg_partition_columns() {
return partition_columns;
}
-Status VIcebergTableWriter::write(vectorized::Block& block) {
+Status VIcebergTableWriter::write(RuntimeState* state, vectorized::Block&
block) {
Review Comment:
warning: function 'write' has cognitive complexity of 85 (threshold 50)
[readability-function-cognitive-complexity]
```cpp
Status VIcebergTableWriter::write(RuntimeState* state, vectorized::Block&
block) {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:109:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (block.rows() == 0) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:113:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(vectorized::VExprContext::get_output_block_after_execute_exprs(
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:113:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(vectorized::VExprContext::get_output_block_after_execute_exprs(
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:120:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
if (_iceberg_partition_columns.empty()) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:125:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (writer_iter == _partitions_to_writers.end()) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:128:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
} catch (doris::Exception& e) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:132:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(writer->open(_state, _profile));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:132:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(writer->open(_state, _profile));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:133:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:134:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (writer_iter->second->written_len() >
config::iceberg_sink_max_file_size) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:145:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
} catch (doris::Exception& e) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:149:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(writer->open(_state, _profile));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:149:** +5,
including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(writer->open(_state, _profile));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:150:** +1,
nesting level increased to 3
```cpp
} else {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:157:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(writer->write(output_block));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:157:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(writer->write(output_block));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:168:** +1,
including nesting penalty of 0, nesting level increased to 1
```cpp
for (int i = 0; i < output_block.rows(); ++i) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:172:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
} catch (doris::Exception& e) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:179:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
} catch (doris::Exception& e) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:183:** nesting
level increased to 2
```cpp
[&](const std::string& partition_name, int position,
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:189:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(writer->open(_state, _profile));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:189:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(writer->open(_state, _profile));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:195:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
} catch (doris::Exception& e) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:202:** +2,
including nesting penalty of 1, nesting level increased to 2
```cpp
if (writer_iter == _partitions_to_writers.end()) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:204:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (_partitions_to_writers.size() + 1 >
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:210:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(create_and_open_writer(partition_name, i,
nullptr, 0, writer));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:210:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(create_and_open_writer(partition_name, i,
nullptr, 0, writer));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:211:** +1,
nesting level increased to 2
```cpp
} else {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:213:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (writer_iter->second->written_len() >
config::iceberg_sink_max_file_size) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:222:** +4,
including nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(create_and_open_writer(partition_name,
i, &file_name,
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:222:** +5,
including nesting penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(create_and_open_writer(partition_name,
i, &file_name,
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:224:** +1,
nesting level increased to 3
```cpp
} else {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:228:** +3,
including nesting penalty of 2, nesting level increased to 3
```cpp
if (writer_pos_iter == writer_positions.end()) {
^
```
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:232:** +1,
nesting level increased to 3
```cpp
} else {
^
```
</details>
##########
be/src/vec/sink/writer/vhive_table_writer.cpp:
##########
@@ -81,7 +81,7 @@ Status VHiveTableWriter::open(RuntimeState* state,
RuntimeProfile* profile) {
return Status::OK();
}
-Status VHiveTableWriter::write(vectorized::Block& block) {
+Status VHiveTableWriter::write(RuntimeState* state, vectorized::Block& block) {
Review Comment:
warning: function 'write' has cognitive complexity of 83 (threshold 50)
[readability-function-cognitive-complexity]
```cpp
Status VHiveTableWriter::write(RuntimeState* state, vectorized::Block&
block) {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/sink/writer/vhive_table_writer.cpp:86:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (block.rows() == 0) {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:90:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(vectorized::VExprContext::get_output_block_after_execute_exprs(
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:90:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(vectorized::VExprContext::get_output_block_after_execute_exprs(
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:98:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (_partition_columns_input_index.empty()) {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:103:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (writer_iter == _partitions_to_writers.end()) {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:106:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
} catch (doris::Exception& e) {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:110:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(writer->open(_state, _profile));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:110:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(writer->open(_state, _profile));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:111:** +1, nesting level
increased to 2
```cpp
} else {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:112:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (writer_iter->second->written_len() >
config::hive_sink_max_file_size) {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:123:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
} catch (doris::Exception& e) {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:127:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(writer->open(_state, _profile));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:127:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(writer->open(_state, _profile));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:128:** +1, nesting level
increased to 3
```cpp
} else {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:135:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(writer->write(output_block));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:135:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(writer->write(output_block));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:141:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
for (int i = 0; i < output_block.rows(); ++i) {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:145:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
} catch (doris::Exception& e) {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:152:** nesting level
increased to 2
```cpp
[&](const std::string& partition_name, int position,
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:158:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(writer->open(_state, _profile));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:158:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(writer->open(_state, _profile));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:164:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
} catch (doris::Exception& e) {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:171:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (writer_iter == _partitions_to_writers.end()) {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:173:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (_partitions_to_writers.size() + 1 >
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:179:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(create_and_open_writer(partition_name, i,
nullptr, 0, writer));
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:179:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(create_and_open_writer(partition_name, i,
nullptr, 0, writer));
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:180:** +1, nesting level
increased to 2
```cpp
} else {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:182:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (writer_iter->second->written_len() >
config::hive_sink_max_file_size) {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:191:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(create_and_open_writer(partition_name,
i, &file_name,
^
```
**be/src/common/status.h:626:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:191:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
RETURN_IF_ERROR(create_and_open_writer(partition_name,
i, &file_name,
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:193:** +1, nesting level
increased to 3
```cpp
} else {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:197:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (writer_pos_iter == writer_positions.end()) {
^
```
**be/src/vec/sink/writer/vhive_table_writer.cpp:201:** +1, nesting level
increased to 3
```cpp
} else {
^
```
</details>
##########
be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:
##########
@@ -105,7 +105,7 @@
return partition_columns;
}
-Status VIcebergTableWriter::write(vectorized::Block& block) {
+Status VIcebergTableWriter::write(RuntimeState* state, vectorized::Block&
block) {
Review Comment:
warning: function 'write' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status VIcebergTableWriter::write(RuntimeState* state, vectorized::Block&
block) {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/sink/writer/iceberg/viceberg_table_writer.cpp:107:** 139 lines
including whitespace and comments (threshold 80)
```cpp
Status VIcebergTableWriter::write(RuntimeState* state, vectorized::Block&
block) {
^
```
</details>
##########
be/src/vec/sink/writer/vhive_table_writer.cpp:
##########
@@ -81,7 +81,7 @@
return Status::OK();
}
-Status VHiveTableWriter::write(vectorized::Block& block) {
+Status VHiveTableWriter::write(RuntimeState* state, vectorized::Block& block) {
Review Comment:
warning: function 'write' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status VHiveTableWriter::write(RuntimeState* state, vectorized::Block&
block) {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/sink/writer/vhive_table_writer.cpp:83:** 132 lines including
whitespace and comments (threshold 80)
```cpp
Status VHiveTableWriter::write(RuntimeState* state, vectorized::Block&
block) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
