HappenLee commented on code in PR #36307:
URL: https://github.com/apache/doris/pull/36307#discussion_r1640779379
##########
be/src/olap/memtable_memory_limiter.cpp:
##########
@@ -225,10 +225,8 @@ void MemTableMemoryLimiter::refresh_mem_tracker() {
_log_timer.reset();
// if not exist load task, this log should not be printed.
if (_mem_usage != 0) {
- LOG(INFO) << ss.str() << ", process mem: " <<
PerfCounters::get_vm_rss_str()
- << " (without allocator cache: "
- <<
PrettyPrinter::print_bytes(GlobalMemoryArbitrator::process_memory_usage())
- << "), load mem: " <<
PrettyPrinter::print_bytes(_mem_tracker->consumption())
+ LOG(INFO) << ss.str() << ", " <<
GlobalMemoryArbitrator::process_memory_used_details_str()
Review Comment:
better do not use streamstringļ¼use fmt to same work. the stringstream bad
performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]