platoneko commented on code in PR #37165:
URL: https://github.com/apache/doris/pull/37165#discussion_r1666454425
##########
common_cpp/sync_point.h:
##########
@@ -259,15 +259,12 @@ auto try_any_cast_ret(std::vector<std::any>& any) {
# define TEST_INJECTION_POINT_RETURN_WITH_VOID(x, ...)
# define TEST_INJECTION_POINT_SINGLETON()
#else
-namespace doris::config {
-extern bool enable_injection_point;
-}
-# define TEST_INJECTION_POINT(x) if (doris::config::enable_injection_point) {
LOG_INFO("enter inject point {}", x); SYNC_POINT(x); }
-# define TEST_IDX_INJECTION_POINT(x, index) if
(doris::config::enable_injection_point) { LOG_INFO("enter inject point {}", x);
IDX_SYNC_POINT(x, index); }
-# define TEST_INJECTION_POINT_CALLBACK(x, ...) if
(doris::config::enable_injection_point) { LOG_INFO("enter inject point {}", x);
SYNC_POINT_CALLBACK(x, __VA_ARGS__); }
-# define TEST_INJECTION_POINT_SINGLETON() if
(doris::config::enable_injection_point) { LOG_INFO("enter inject point {}", x);
SYNC_POINT_SINGLETON(); }
-# define TEST_INJECTION_POINT_RETURN_WITH_VALUE(x, default_ret_val, ...) if
(doris::config::enable_injection_point) { LOG_INFO("enter inject point {}", x);
SYNC_POINT_RETURN_WITH_VALUE(x, default_ret_val, __VA_ARGS__); }
-# define TEST_INJECTION_POINT_RETURN_WITH_VOID(x, ...) if
(doris::config::enable_injection_point) { LOG_INFO("enter inject point {}", x);
SYNC_POINT_RETURN_WITH_VOID(x, __VA_ARGS__); }
+# define TEST_INJECTION_POINT(x) SYNC_POINT(x);
Review Comment:
Injection points will be enabled via http api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
