morrySnow commented on code in PR #37561:
URL: https://github.com/apache/doris/pull/37561#discussion_r1680527087
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -560,10 +560,16 @@ public class SessionVariable implements Serializable,
Writable {
public static final String ENABLE_MATERIALIZED_VIEW_REWRITE
= "enable_materialized_view_rewrite";
+ public static final String ENABLE_DML_MATERIALIZED_VIEW_REWRITE
+ = "enable_dml_materialized_view_rewrite";
+
+ public static final String
ENABLE_DML_MATERIALIZED_VIEW_REWRITE_WHEN_BASE_TABLE_UNAWARENESS
+ =
"enable_dml_materialized_view_rewrite_when_base_table_unawareness";
Review Comment:
unawareness? is it a standard phrases?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/NereidsPlanner.java:
##########
@@ -286,6 +289,12 @@ private void analyze(boolean showPlanProcess) {
LOG.debug("Start analyze plan");
}
keepOrShowPlanProcess(showPlanProcess, () ->
cascadesContext.newAnalyzer().analyze());
+ if
(this.cascadesContext.getConnectContext().getSessionVariable().isEnableDmlMaterializedViewRewrite()
Review Comment:
u should add a analysis rule and check do this in rule. move hooks from
NereidsPlanner into StatementContext
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
