morningman commented on a change in pull request #8450:
URL: https://github.com/apache/incubator-doris/pull/8450#discussion_r824748122
##########
File path: be/src/vec/columns/column_vector.cpp
##########
@@ -231,8 +231,8 @@ void ColumnVector<T>::insert_indices_from(const IColumn&
src, const int* indices
// Now Uint8 use to identify null and non null
// 1. nullable column : offset == -1 means is null at the here,
set true here
// 2. real data column : offset == -1 what at is meaningless
- // 3. -1 only use in outer join to hint the null is produced by
outer join
- data[origin_size + i] = (offset == -1) ? UInt8(-1) :
src_vec.get_element(offset);
+ // 3. 2 only use in outer join to hint the null is produced by
outer join
+ data[origin_size + i] = (offset == -1) ? 2 :
src_vec.get_element(offset);
Review comment:
define `2` somewhere as a constant, to avoid magic number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
