morningman commented on code in PR #38408:
URL: https://github.com/apache/doris/pull/38408#discussion_r1692616237
##########
be/src/vec/data_types/data_type_struct.cpp:
##########
@@ -355,14 +355,7 @@ std::optional<size_t>
DataTypeStruct::try_get_position_by_name(const String& nam
}
String DataTypeStruct::get_name_by_position(size_t i) const {
- if (i == 0 || i > names.size()) {
- fmt::memory_buffer error_msg;
- fmt::format_to(error_msg, "Index of tuple element ({}) if out range
([1, {}])", i,
- names.size());
- LOG(FATAL) << fmt::to_string(error_msg);
- }
-
- return names[i - 1];
+ return names[i];
Review Comment:
Why removing this check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
