xiaokang commented on code in PR #38413:
URL: https://github.com/apache/doris/pull/38413#discussion_r1694230848
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -699,6 +699,11 @@ Status
SegmentIterator::_get_row_ranges_from_conditions(RowRanges* condition_row
if (_opts.io_ctx.reader_type == ReaderType::READER_QUERY) {
RowRanges dict_row_ranges = RowRanges::create_single(num_rows());
for (auto cid : cids) {
+ if (!_segment->can_apply_predicate_safely(cid,
Review Comment:
There is check for can_apply_predicate_safely() in bf and zonemap branch.
Why it's not check in this branch before? Does this modification affect other
logic in this branch?
##########
be/src/vec/data_types/data_type_object.cpp:
##########
@@ -121,6 +126,11 @@ char* DataTypeObject::serialize(const IColumn& column,
char* buf, int be_exec_ve
}
// serialize num of subcolumns
*reinterpret_cast<uint32_t*>(size_pos) = num_of_columns;
+ if (num_of_columns == 0) {
+ // Make sure the num_of_rows in ColumnObject not lost
+ *reinterpret_cast<uint32_t*>(buf) = column_object.rows();
Review Comment:
1. Why only serialize num_rows when num_of_columns == 0?
2. It may cause error when rolling upgrade be if serialization is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
