github-actions[bot] commented on code in PR #38403:
URL: https://github.com/apache/doris/pull/38403#discussion_r1694447267
##########
be/src/exec/schema_scanner/schema_active_queries_scanner.cpp:
##########
@@ -47,10 +48,15 @@ SchemaActiveQueriesScanner::~SchemaActiveQueriesScanner() {}
Status SchemaActiveQueriesScanner::start(RuntimeState* state) {
_block_rows_limit = state->batch_size();
_rpc_timeout = state->execution_timeout() * 1000;
- return Status::OK();
+ return SchemaScanner::start(state);
}
-Status SchemaActiveQueriesScanner::_get_active_queries_block_from_fe() {
+void SchemaActiveQueriesScanner::_get_next_block_internal(RuntimeState* state)
{
Review Comment:
warning: function '_get_next_block_internal' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
void SchemaActiveQueriesScanner::_get_next_block_internal(RuntimeState*
state) {
^
```
<details>
<summary>Additional context</summary>
**be/src/exec/schema_scanner/schema_active_queries_scanner.cpp:53:** 99
lines including whitespace and comments (threshold 80)
```cpp
void SchemaActiveQueriesScanner::_get_next_block_internal(RuntimeState*
state) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
