biohazard4321 opened a new pull request, #38510:
URL: https://github.com/apache/doris/pull/38510

   ## Proposed changes
   deploy manager always throws an exception:
   java.nio.channels.ClosedChannelException: null
           at sun.nio.ch.FileLockImpl.release(FileLockImpl.java:58) 
~[?:1.8.0_161]
           at 
org.apache.doris.deploy.impl.LocalFileDeployManager.getGroupHostInfos(LocalFileDeployManager.java:136)
 ~[doris-fe.jar:1.2-SNAPSHOT]
           at 
org.apache.doris.deploy.DeployManager.processPolling(DeployManager.java:369) 
~[doris-fe.jar:1.2-SNAPSHOT]
           at 
org.apache.doris.deploy.DeployManager.runAfterCatalogReady(DeployManager.java:355)
 ~[doris-fe.jar:1.2-SNAPSHOT]
           at 
org.apache.doris.common.util.MasterDaemon.runOneCycle(MasterDaemon.java:58) 
~[doris-fe.jar:1.2-SNAPSHOT]
           at org.apache.doris.common.util.Daemon.run(Daemon.java:116) 
~[doris-fe.jar:1.2-SNAPSHOT]
   
   Because close stream and bufferedreader also close the channel,and the file 
lock is no need to release anymore.
   Also the channel is no need to close; a channel from FileInputStream will 
autoclose after the stream's close. So the finally block is really unnecessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to