HappenLee commented on code in PR #38360:
URL: https://github.com/apache/doris/pull/38360#discussion_r1696387777
##########
be/src/util/simd/bits.h:
##########
@@ -21,18 +21,42 @@
#include <cstring>
#include <vector>
+#if defined(__ARM_NEON) && defined(__aarch64__)
+#include <arm_neon.h>
+#endif
+
#include "util/sse_util.hpp"
namespace doris {
namespace simd {
-/// todo(zeno) Compile add avx512 parameter, modify it to
bytes64_mask_to_bits64_mask
-/// Transform 32-byte mask to 32-bit mask
-inline uint32_t bytes32_mask_to_bits32_mask(const uint8_t* data) {
+consteval inline auto bits_mask_length() {
Review Comment:
no need add `inline` keyword
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
