This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-2.1 by this push:
     new c310b92727d [bugfix](external)Modify the default value of 
`pushdowncount` for 2.1 (#37754) (#38591)
c310b92727d is described below

commit c310b92727df4350c170919d97709a4123396bd7
Author: wuwenchi <[email protected]>
AuthorDate: Thu Aug 1 12:10:54 2024 +0800

    [bugfix](external)Modify the default value of `pushdowncount` for 2.1 
(#37754) (#38591)
    
    bp: #37754
---
 .../src/main/java/org/apache/doris/datasource/FileScanNode.java      | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/datasource/FileScanNode.java 
b/fe/fe-core/src/main/java/org/apache/doris/datasource/FileScanNode.java
index 11a7b13024e..d202e01f524 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/datasource/FileScanNode.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/datasource/FileScanNode.java
@@ -98,7 +98,10 @@ public abstract class FileScanNode extends ExternalScanNode {
     }
 
     public long getPushDownCount() {
-        return 0;
+        // 1. Do not use `0`: If the number of entries in the table is 0,
+        //                    it is unclear whether optimization has been 
performed.
+        // 2. Do not use `null` or `-`: This makes it easier for the program 
to parse the `explain` data.
+        return -1;
     }
 
     @Override


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to