SWJTU-ZhangLei commented on code in PR #39372:
URL: https://github.com/apache/doris/pull/39372#discussion_r1718028622
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -406,7 +406,7 @@ void
MetaServiceImpl::batch_get_version(::google::protobuf::RpcController* contr
void internal_create_tablet(MetaServiceCode& code, std::string& msg,
const doris::TabletMetaCloudPB& meta,
std::shared_ptr<TxnKv> txn_kv,
const std::string& instance_id,
- std::set<std::pair<int64_t, int32_t>>&
saved_schema) {
+ std::set<std::pair<int64_t, int32_t>>&
saved_schema, int64_t db_id) {
Review Comment:
> MS may serve an older version of FE, so db_id has not been set. It would
be more appropriate to use `std::optional<int64_t>` here and check
`request.has_db_id()` when calling.
resolved, i not use std::optional instead of using request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
