cambyzju commented on a change in pull request #8764:
URL: https://github.com/apache/incubator-doris/pull/8764#discussion_r839136520
##########
File path: be/src/exec/olap_scanner.cpp
##########
@@ -335,6 +335,7 @@ Status OlapScanner::get_batch(RuntimeState* state,
RowBatch* batch, bool* eof) {
// make sure to reset null indicators since we're
overwriting
// the tuple assembled for the previous row
tuple->init(_tuple_desc->byte_size());
+ batch->agg_object_pool()->remove_last_one();
Review comment:
Could you give some more detail about the OOM?
If one thread(T2) add an new object into agg_object_pool, just before
remove_last_one called by this thread(T1).
I think it may remove object added by T2, not the one added by T1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
