EmmyMiao87 commented on code in PR #8857:
URL: https://github.com/apache/incubator-doris/pull/8857#discussion_r844609901
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/TableRef.java:
##########
@@ -572,7 +580,12 @@ public void analyzeJoin(Analyzer analyzer) throws
AnalysisException {
public void rewriteExprs(ExprRewriter rewriter, Analyzer analyzer)
throws AnalysisException {
Preconditions.checkState(isAnalyzed);
- if (onClause != null) onClause = rewriter.rewrite(onClause, analyzer,
ExprRewriter.ClauseType.ON_CLAUSE);
+ if (onClause != null) {
Review Comment:
What was the predicate ```a.k1=b.k1 and 1=2 ``` changed to before this PR?
##########
fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java:
##########
@@ -2112,4 +2112,38 @@ public void testInsertIntoSelect() throws Exception {
String explainString =
UtFrameUtils.getSQLPlanOrErrorMsg(connectContext, sql);
Assert.assertTrue(explainString.contains("1 | 10 | 1 | 1 | 1"));
}
+
Review Comment:
Link issue in the comment ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
