MaoMiMao commented on code in PR #479: URL: https://github.com/apache/doris-flink-connector/pull/479#discussion_r1736041136
########## flink-doris-connector/src/main/java/org/apache/doris/flink/source/DorisSource.java: ########## @@ -95,6 +100,15 @@ public SourceReader<OUT, DorisSourceSplit> createReader(SourceReaderContext read public SplitEnumerator<DorisSourceSplit, PendingSplitsCheckpoint> createEnumerator( SplitEnumeratorContext<DorisSourceSplit> context) throws Exception { List<DorisSourceSplit> dorisSourceSplits = new ArrayList<>(); + if (!resolvedFilterQuery.isEmpty()) { + String collect = String.join(" AND ", resolvedFilterQuery); Review Comment: GET ########## flink-doris-connector/src/test/java/org/apache/doris/flink/source/DorisSourceITCase.java: ########## @@ -67,6 +67,7 @@ public void testSource() throws Exception { DorisSource<List<?>> source = DorisSource.<List<?>>builder() .setDorisOptions(dorisBuilder.build()) + .setResolvedFilterQuery(new ArrayList<>()) Review Comment: GET -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org