feiniaofeiafei commented on code in PR #39450:
URL: https://github.com/apache/doris/pull/39450#discussion_r1737856490
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java:
##########
@@ -306,24 +318,11 @@ public class Rewriter extends AbstractBatchJobExecutor {
// after eliminate outer join, we can move some
filters to join.otherJoinConjuncts,
// this can help to translate plan to backend
topDown(new PushFilterInsideJoin()),
- topDown(new FindHashConditionForJoin()),
- topDown(new ExpressionNormalization())
Review Comment:
It seems that deleting it is fine, because the PushFilterInsideJoin and
FindHashConditionForJoin rules do not make any expression changes. All the
necessary expression changes are done in PUSH_DOWN_FILTERS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
